Node management - Refresh #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djw-m
changed the title
djw-m
added
the
deploy
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
djw-m
force-pushed
the
docs/pgd/poc/nodereorg
branch
from
a2b1d4b to
2c8d890
Compare
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
djw-m
force-pushed
the
docs/pgd/poc/nodereorg
branch
from
2b127d5 to
ef59456
Compare
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
djw-m
force-pushed
the
docs/pgd/poc/nodereorg
branch
from
ef59456 to
a5ea88d
Compare
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
|
Nice work! The easiest way to review this PR is likely by comparing the current to the proposed structure. Assuming that this PR is primarily about re-arranging existing content, this looks good to me. Thanks for breaking this up! |
LenzGr
reviewed
Oct 5, 2023
djw-m
force-pushed
the
docs/pgd/poc/nodereorg
branch
from
fa33b5a to
200680a
Compare
github-actions
bot
temporarily deployed
to
pr-4849-docs-pgd-poc-nodereorg
LenzGr
reviewed
Oct 6, 2023
josh-heyer
requested changes
Oct 6, 2023
There was a problem hiding this comment.
Link-checker found a few outstanding links to the old nodes page that'll need to be updated:
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/consistency/conflicts/
- (172:237) 'Node res..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/ (HTTP 404)
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/monitoring/sql/
- (271:840) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
- (281:10) 'logical ..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#logical-standby-nodes (HTTP 404)
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/postgres-configuration/
- (124:63) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/reference/functions/
- (392:902) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
- (394:3287) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/reference/nodes-management-interfaces/
- (153:28) 'Subscrib..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#subscriber-only-groups (HTTP 404)
https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/reference/pgd-settings/
- (273:4089) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
- (273:6965) 'decoding..' => https://deploy-preview-4849--edb-docs-staging.netlify.app/docs/pgd/latest/nodes/#decoding-worker (HTTP 404)
Other link-related issues noted below:
product_docs/docs/pgd/5/node_management/logical_standby_nodes.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/pgd/5/node_management/physical_standby_nodes.mdx
Outdated
Show resolved
Hide resolved
josh-heyer
previously approved these changes
Oct 6, 2023
product_docs/docs/pgd/5/node_management/connections_dsns_and_ssl.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/pgd/5/node_management/connections_dsns_and_ssl.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lenz Grimmer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
Co-authored-by: Josh Heyer <[email protected]>
….mdx Co-authored-by: Josh Heyer <[email protected]>
One read-through as these have been edited in the past
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
josh-heyer
force-pushed
the
docs/pgd/poc/nodereorg
branch
from
dcdd036 to
6a41f3b
Compare
josh-heyer
approved these changes
Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Node section broken out into smaller sections for redevelopment, top section intro and pointers added.
https://enterprisedb.atlassian.net/browse/BDR-4238